From: Dinghao Liu Date: Sun, 24 May 2020 02:59:02 +0000 (+0200) Subject: media: exynos4-is: Fix runtime PM imbalance in fimc_is_probe X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=4f9b5709cc087337bf02f004f0a238ec7ebda25b;p=linux.git media: exynos4-is: Fix runtime PM imbalance in fimc_is_probe pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. For all error paths after pm_runtime_get_sync(), things are the same. Signed-off-by: Dinghao Liu Reviewed-by: Sylwester Nawrocki Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/exynos4-is/fimc-is.c b/drivers/media/platform/exynos4-is/fimc-is.c index 64148b7e0d986..a474014f0a0fa 100644 --- a/drivers/media/platform/exynos4-is/fimc-is.c +++ b/drivers/media/platform/exynos4-is/fimc-is.c @@ -871,6 +871,7 @@ err_dfs: err_sd: fimc_is_unregister_subdevs(is); err_pm: + pm_runtime_put_noidle(dev); if (!pm_runtime_enabled(dev)) fimc_is_runtime_suspend(dev); err_irq: