From: David Sterba Date: Tue, 23 Jan 2024 22:09:18 +0000 (+0100) Subject: btrfs: change BUG_ON to assertion when verifying lockdep class setup X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=504a00ac48a714845e4ae0593b4ab715f93ac297;p=linux.git btrfs: change BUG_ON to assertion when verifying lockdep class setup The BUG_ON in btrfs_set_buffer_lockdep_class() is a sanity check of the level which is verified in callers, e.g. when initializing an extent buffer or reading from an eb header. Change it to an assertion as this would not happen unless things are really bad and would fail elsewhere too. Reviewed-by: Josef Bacik Reviewed-by: Anand Jain Signed-off-by: David Sterba --- diff --git a/fs/btrfs/locking.c b/fs/btrfs/locking.c index 286e6aa721c73..99ccab86bb865 100644 --- a/fs/btrfs/locking.c +++ b/fs/btrfs/locking.c @@ -84,7 +84,7 @@ void btrfs_set_buffer_lockdep_class(u64 objectid, struct extent_buffer *eb, int { struct btrfs_lockdep_keyset *ks; - BUG_ON(level >= ARRAY_SIZE(ks->keys)); + ASSERT(level < ARRAY_SIZE(ks->keys)); /* Find the matching keyset, id 0 is the default entry */ for (ks = btrfs_lockdep_keysets; ks->id; ks++)