From: J. Bruce Fields <bfields@redhat.com>
Date: Fri, 25 Sep 2020 14:09:58 +0000 (-0400)
Subject: nfsd4: remove check_conflicting_opens warning
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=50747dd5e47bde3b7d7f839c84d0d3b554090497;p=linux.git

nfsd4: remove check_conflicting_opens warning

There are actually rare races where this is possible (e.g. if a new open
intervenes between the read of i_writecount and the fi_fds).

Signed-off-by: J. Bruce Fields <bfields@redhat.com>
---

diff --git a/fs/nfsd/nfs4state.c b/fs/nfsd/nfs4state.c
index 726046b6b370a..a59551efd263e 100644
--- a/fs/nfsd/nfs4state.c
+++ b/fs/nfsd/nfs4state.c
@@ -4955,7 +4955,6 @@ static int nfsd4_check_conflicting_opens(struct nfs4_client *clp,
 		writes--;
 	if (fp->fi_fds[O_RDWR])
 		writes--;
-	WARN_ON_ONCE(writes < 0);
 	if (writes > 0)
 		return -EAGAIN;
 	spin_lock(&fp->fi_lock);