From: Li Chen Date: Tue, 21 Dec 2021 02:59:56 +0000 (+0000) Subject: PCI: endpoint: Return -EINVAL when interrupts num is smaller than 1 X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=50b620303a14e885529410d26800f92a735724d6;p=linux.git PCI: endpoint: Return -EINVAL when interrupts num is smaller than 1 In pci_epc_set_msi() we should return immediately if there are no interrupts to configure; update the code to return early. Link: https://lore.kernel.org/r/CH2PR19MB402491B9E503694DBCAC6005A07C9@CH2PR19MB4024.namprd19.prod.outlook.com Signed-off-by: Li Chen Signed-off-by: Lorenzo Pieralisi Reviewed-by: Kishon Vijay Abraham I --- diff --git a/drivers/pci/endpoint/pci-epc-core.c b/drivers/pci/endpoint/pci-epc-core.c index 38621558d3975..3bc9273d0a082 100644 --- a/drivers/pci/endpoint/pci-epc-core.c +++ b/drivers/pci/endpoint/pci-epc-core.c @@ -334,7 +334,7 @@ int pci_epc_set_msi(struct pci_epc *epc, u8 func_no, u8 vfunc_no, u8 interrupts) u8 encode_int; if (IS_ERR_OR_NULL(epc) || func_no >= epc->max_functions || - interrupts > 32) + interrupts < 1 || interrupts > 32) return -EINVAL; if (vfunc_no > 0 && (!epc->max_vfs || vfunc_no > epc->max_vfs[func_no]))