From: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Date: Tue, 18 Oct 2011 17:17:56 +0000 (+0400)
Subject: qed: remove unneeded variable assignment
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=512a2cf8e9c52ac72cace5572eed16f9003cd11c;p=qemu.git

qed: remove unneeded variable assignment

'ret' is unconditionally overwitten by qed_read_l1_table_sync()

Spotted by Clang Analyzer

Signed-off-by: Pavel Borzenkov <pavel.borzenkov@gmail.com>
Signed-off-by: Stefan Hajnoczi <stefanha@linux.vnet.ibm.com>
---

diff --git a/block/qed.c b/block/qed.c
index 7fab155b1a..e6720dbd6f 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -388,7 +388,6 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags)
     if (ret < 0) {
         return ret;
     }
-    ret = 0; /* ret should always be 0 or -errno */
     qed_header_le_to_cpu(&le_header, &s->header);
 
     if (s->header.magic != QED_MAGIC) {