From: Matthew Auld Date: Mon, 19 Jun 2023 11:00:20 +0000 (+0100) Subject: drm/xe/bo: consider bo->flags in xe_bo_migrate() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=513e82627931d0ac6b74b9c2595008b3573a5158;p=linux.git drm/xe/bo: consider bo->flags in xe_bo_migrate() For VRAM allocations the bo->flags can control some characteristics of the underlying memory, like whether it needs to be contiguous, and in the future whether it needs to be in the CPU visible portion. Rather use add_vram() in xe_bo_migrate() which should take care of such things for us. Signed-off-by: Matthew Auld Cc: Thomas Hellström Cc: José Roberto de Souza Reviewed-by: José Roberto de Souza Signed-off-by: Rodrigo Vivi --- diff --git a/drivers/gpu/drm/xe/xe_bo.c b/drivers/gpu/drm/xe/xe_bo.c index ad0ea3014bfee..f54fb7bd184a5 100644 --- a/drivers/gpu/drm/xe/xe_bo.c +++ b/drivers/gpu/drm/xe/xe_bo.c @@ -1852,6 +1852,7 @@ static void xe_place_from_ttm_type(u32 mem_type, struct ttm_place *place) */ int xe_bo_migrate(struct xe_bo *bo, u32 mem_type) { + struct xe_device *xe = ttm_to_xe_device(bo->ttm.bdev); struct ttm_operation_ctx ctx = { .interruptible = true, .no_wait_gpu = false, @@ -1876,6 +1877,18 @@ int xe_bo_migrate(struct xe_bo *bo, u32 mem_type) placement.placement = &requested; placement.busy_placement = &requested; + /* + * Stolen needs to be handled like below VRAM handling if we ever need + * to support it. + */ + drm_WARN_ON(&xe->drm, mem_type == XE_PL_STOLEN); + + if (mem_type_is_vram(mem_type)) { + u32 c = 0; + + add_vram(xe, bo, &requested, bo->flags, mem_type, &c); + } + return ttm_bo_validate(&bo->ttm, &placement, &ctx); }