From: Liang He <windhl@126.com>
Date: Wed, 15 Jun 2022 12:51:05 +0000 (+0800)
Subject: w1: Add missing of_node_put() in w1.c
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=51cbbcd6469b2a32e222ec220039af20a16f2769;p=linux.git

w1: Add missing of_node_put() in w1.c

In __w1_attach_slave_device, we really need not to use of_node_put
in normal path as the reference is escaped by sl. However, we need
of_node_put in the fail path before put_device.

Signed-off-by: Liang He <windhl@126.com>
Link: https://lore.kernel.org/r/20220615125105.3966317-1-windhl@126.com
[krzysztof: fix whitespace / checkpatch]
Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
---

diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index bc11cdd2e4f23..e16a60872226d 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -692,6 +692,7 @@ static int __w1_attach_slave_device(struct w1_slave *sl)
 		dev_err(&sl->dev,
 			"Device registration [%s] failed. err=%d\n",
 			dev_name(&sl->dev), err);
+		of_node_put(sl->dev.of_node);
 		put_device(&sl->dev);
 		return err;
 	}