From: David Sterba <dsterba@suse.com>
Date: Fri, 19 Jan 2024 19:15:41 +0000 (+0100)
Subject: btrfs: defrag: change BUG_ON to assertion in btrfs_defrag_leaves()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=51d4be540054be32d7ce28b63ea9b84ac6ff1db2;p=linux.git

btrfs: defrag: change BUG_ON to assertion in btrfs_defrag_leaves()

The BUG_ON verifies a condition that should be guaranteed by the correct
use of the path search (with keep_locks and lowest_level set), an
assertion is the suitable check.

Reviewed-by: Josef Bacik <josef@toxicpanda.com>
Reviewed-by: Anand Jain <anand.jain@oracle.com>
Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/btrfs/defrag.c b/fs/btrfs/defrag.c
index eb62ff490c48c..6f49de3ec92f8 100644
--- a/fs/btrfs/defrag.c
+++ b/fs/btrfs/defrag.c
@@ -520,7 +520,7 @@ static int btrfs_defrag_leaves(struct btrfs_trans_handle *trans,
 	 * keep_locks set and lowest_level is 1, regardless of the value of
 	 * path->slots[1].
 	 */
-	BUG_ON(path->locks[1] == 0);
+	ASSERT(path->locks[1] != 0);
 	ret = btrfs_realloc_node(trans, root,
 				 path->nodes[1], 0,
 				 &last_ret,