From: Fam Zheng Date: Mon, 17 Sep 2018 08:31:38 +0000 (+0800) Subject: scsi-block: Deprecate rotation_rate X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=51f43d5792e3d7a52c0be380e9b855fc4a05a816;p=qemu.git scsi-block: Deprecate rotation_rate This option is added together with scsi-disk but is never honoured, becuase we don't emulate the VPD page for scsi-block. We could intercept and inject the user specified value like for max xfer len, but it's probably not helpful since the intent of 070f80095ad was for random entropy aspects, not for performance. If emulated rotation rate is desired, scsi-hd is more suitable. Signed-off-by: Fam Zheng Message-Id: <20180917083138.3948-1-famz@redhat.com> Signed-off-by: Paolo Bonzini --- diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 5ae7baa082..c43163cef4 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -2610,6 +2610,12 @@ static void scsi_block_realize(SCSIDevice *dev, Error **errp) return; } + if (s->rotation_rate) { + error_report_once("rotation_rate is specified for scsi-block but is " + "not implemented. This option is deprecated and will " + "be removed in a future version"); + } + /* check we are using a driver managing SG_IO (version 3 and after) */ rc = blk_ioctl(s->qdev.conf.blk, SG_GET_VERSION_NUM, &sg_version); if (rc < 0) {