From: Klaus Jensen <k.jensen@samsung.com>
Date: Thu, 10 Dec 2020 07:11:32 +0000 (+0100)
Subject: hw/block/nvme: remove unnecessary check for append
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=521ea778b264116310182db9c4d329c5aa867c59;p=qemu.git

hw/block/nvme: remove unnecessary check for append

nvme_io_cmd already checks if the namespace supports the Zone Append
command, so the removed check is dead code.

Signed-off-by: Klaus Jensen <k.jensen@samsung.com>
Tested-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
Reviewed-by: Dmitry Fomichev <dmitry.fomichev@wdc.com>
---

diff --git a/hw/block/nvme.c b/hw/block/nvme.c
index 7222eff755..c73afdf805 100644
--- a/hw/block/nvme.c
+++ b/hw/block/nvme.c
@@ -1707,10 +1707,6 @@ static uint16_t nvme_do_write(NvmeCtrl *n, NvmeRequest *req, bool append,
         }
 
         res->slba = nvme_advance_zone_wp(ns, zone, nlb);
-    } else if (append) {
-        trace_pci_nvme_err_invalid_opc(rw->opcode);
-        status = NVME_INVALID_OPCODE;
-        goto invalid;
     }
 
     data_offset = nvme_l2b(ns, slba);