From: David Hildenbrand Date: Wed, 13 Sep 2017 13:24:04 +0000 (+0200) Subject: target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=525f4b65c7d337f0c83488ee1e951a134b6ccfb7;p=qemu.git target/s390x: use trigger_pgm_exception() in s390_cpu_handle_mmu_fault() This looks cleaner. linux-user will not use the ilen field, so setting it doesn't do any harm. Reviewed-by: Thomas Huth Signed-off-by: David Hildenbrand Message-Id: <20170913132417.24384-10-david@redhat.com> Signed-off-by: Cornelia Huck --- diff --git a/target/s390x/excp_helper.c b/target/s390x/excp_helper.c index 361f970db3..14d3160e92 100644 --- a/target/s390x/excp_helper.c +++ b/target/s390x/excp_helper.c @@ -59,8 +59,7 @@ int s390_cpu_handle_mmu_fault(CPUState *cs, vaddr address, { S390CPU *cpu = S390_CPU(cs); - cs->exception_index = EXCP_PGM; - cpu->env.int_pgm_code = PGM_ADDRESSING; + trigger_pgm_exception(&cpu->env, PGM_ADDRESSING, ILEN_AUTO); /* On real machines this value is dropped into LowMem. Since this is userland, simply put this someplace that cpu_loop can find it. */ cpu->env.__excp_addr = address;