From: Krzysztof Kozlowski Date: Wed, 26 Aug 2020 14:48:56 +0000 (+0200) Subject: power: supply: gpio-charger: Simplify with dev_err_probe() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=52a023a14ea90da4356395f175cf055d6ad8afee;p=linux.git power: supply: gpio-charger: Simplify with dev_err_probe() Common pattern of handling deferred probe can be simplified with dev_err_probe(). Less code and also it prints the error value. Signed-off-by: Krzysztof Kozlowski Signed-off-by: Sebastian Reichel --- diff --git a/drivers/power/supply/gpio-charger.c b/drivers/power/supply/gpio-charger.c index 875735d50716b..557f879a6499b 100644 --- a/drivers/power/supply/gpio-charger.c +++ b/drivers/power/supply/gpio-charger.c @@ -173,10 +173,8 @@ static int gpio_charger_probe(struct platform_device *pdev) gpio_charger->gpiod = gpio_to_desc(pdata->gpio); } else if (IS_ERR(gpio_charger->gpiod)) { /* Just try again if this happens */ - if (PTR_ERR(gpio_charger->gpiod) == -EPROBE_DEFER) - return -EPROBE_DEFER; - dev_err(dev, "error getting GPIO descriptor\n"); - return PTR_ERR(gpio_charger->gpiod); + return dev_err_probe(dev, PTR_ERR(gpio_charger->gpiod), + "error getting GPIO descriptor\n"); } if (gpio_charger->gpiod) {