From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Mon, 29 Jun 2015 17:58:17 +0000 (-0400)
Subject: xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=52c7265f602701751b55d437b347bd73debf9d91;p=qemu.git

xen/pt: xen_host_pci_config_read returns -errno, not -1 on failure

However the init routines assume that on errors the return
code is -1 (as the libxc API is) - while those xen_host_* routines follow
another paradigm - negative errno on return, 0 on success.

Reviewed-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Signed-off-by: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Signed-off-by: Stefano Stabellini <stefano.stabellini@eu.citrix.com>
---

diff --git a/hw/xen/xen_pt.c b/hw/xen/xen_pt.c
index ba043e64af..3b1544c422 100644
--- a/hw/xen/xen_pt.c
+++ b/hw/xen/xen_pt.c
@@ -729,7 +729,7 @@ static int xen_pt_initfn(PCIDevice *d)
 
     /* Initialize virtualized PCI configuration (Extended 256 Bytes) */
     if (xen_host_pci_get_block(&s->real_device, 0, d->config,
-                               PCI_CONFIG_SPACE_SIZE) == -1) {
+                               PCI_CONFIG_SPACE_SIZE) < 0) {
         xen_host_pci_device_put(&s->real_device);
         return -1;
     }