From: Sohil Mehta Date: Thu, 27 Jul 2023 18:05:31 +0000 (+0000) Subject: x86/smpboot: Remove a stray comment about CPU hotplug X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=52defa4a5e719a57992aed52c8d3e214e75ac276;p=linux.git x86/smpboot: Remove a stray comment about CPU hotplug This old comment is irrelavant to the logic of disabling interrupts and could be misleading. Remove it. Now, hlt_play_dead() resembles the code that the comment was initially added for, but, it doesn't make sense anymore because an offlined cpu could also be put into other states such as mwait. Signed-off-by: Sohil Mehta Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20230727180533.3119660-2-sohil.mehta@intel.com --- diff --git a/arch/x86/kernel/smpboot.c b/arch/x86/kernel/smpboot.c index e1aa2cd7734ba..6a09a021b5346 100644 --- a/arch/x86/kernel/smpboot.c +++ b/arch/x86/kernel/smpboot.c @@ -1614,9 +1614,7 @@ void play_dead_common(void) idle_task_exit(); cpuhp_ap_report_dead(); - /* - * With physical CPU hotplug, we should halt the cpu - */ + local_irq_disable(); }