From: Uwe Kleine-König Date: Sat, 16 Jul 2022 14:54:03 +0000 (+0200) Subject: phy: tegra: xusb: Only warn once about reset problems in .remove() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=533e13305c16c63915f7cc8a36ed7ef717e15378;p=linux.git phy: tegra: xusb: Only warn once about reset problems in .remove() The single difference between returning 0 and returning an error code in a platform remove callback is that in the latter case the platform core emits a warning about the error being ignored. If reset_control_assert() fails there is already a warning, so suppress the more generic (and less helpful) by returning 0 in tegra_xusb_padctl_remove(). This is a preparation for making platform remove callbacks return void. Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20220716145403.107703-1-u.kleine-koenig@pengutronix.de Signed-off-by: Vinod Koul --- diff --git a/drivers/phy/tegra/xusb.c b/drivers/phy/tegra/xusb.c index aa5237eacd29d..d04a80c436c36 100644 --- a/drivers/phy/tegra/xusb.c +++ b/drivers/phy/tegra/xusb.c @@ -1270,7 +1270,7 @@ static int tegra_xusb_padctl_remove(struct platform_device *pdev) padctl->soc->ops->remove(padctl); - return err; + return 0; } static __maybe_unused int tegra_xusb_padctl_suspend_noirq(struct device *dev)