From: Andreas Färber <afaerber@suse.de>
Date: Thu, 17 Apr 2014 17:21:12 +0000 (+0200)
Subject: qtest: Be paranoid about accept() addrlen argument
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=535b45631ad7176e10dab89d55443b5a096500b9;p=qemu.git

qtest: Be paranoid about accept() addrlen argument

POSIX specifies that address_len shall on output specify the length of
the stored address; it does not however specify whether it may get
updated on failure as well to, e.g., zero.

In case EINTR occurs, re-initialize the variable to the desired value.

Reviewed-by: Eric Blake <eblake@redhat.com>
Signed-off-by: Andreas Färber <afaerber@suse.de>
---

diff --git a/tests/libqtest.c b/tests/libqtest.c
index 4b90d9112a..71468ac9c7 100644
--- a/tests/libqtest.c
+++ b/tests/libqtest.c
@@ -89,8 +89,8 @@ static int socket_accept(int sock)
     setsockopt(sock, SOL_SOCKET, SO_RCVTIMEO, (void *)&timeout,
                sizeof(timeout));
 
-    addrlen = sizeof(addr);
     do {
+        addrlen = sizeof(addr);
         ret = accept(sock, (struct sockaddr *)&addr, &addrlen);
     } while (ret == -1 && errno == EINTR);
     if (ret == -1) {