From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Thu, 25 Aug 2022 13:25:08 +0000 (+0300)
Subject: net_sched: remove impossible conditions
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=53a406803ca5b0b1f91beffacad4321fae4fa2a7;p=linux.git

net_sched: remove impossible conditions

We no longer allow "handle" to be zero, so there is no need to check
for that.

Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/Ywd4NIoS4aiilnMv@kili
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
---

diff --git a/net/sched/cls_route.c b/net/sched/cls_route.c
index 48712bc51bda7..29adac7812fe6 100644
--- a/net/sched/cls_route.c
+++ b/net/sched/cls_route.c
@@ -488,7 +488,7 @@ static int route4_change(struct net *net, struct sk_buff *in_skb,
 	}
 
 	if (opt == NULL)
-		return handle ? -EINVAL : 0;
+		return -EINVAL;
 
 	err = nla_parse_nested_deprecated(tb, TCA_ROUTE4_MAX, opt,
 					  route4_policy, NULL);
@@ -496,7 +496,7 @@ static int route4_change(struct net *net, struct sk_buff *in_skb,
 		return err;
 
 	fold = *arg;
-	if (fold && handle && fold->handle != handle)
+	if (fold && fold->handle != handle)
 			return -EINVAL;
 
 	err = -ENOBUFS;