From: Colin Ian King Date: Thu, 2 Nov 2017 20:04:12 +0000 (+0000) Subject: net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=53b3847be5cbdf819cf366ea9160369ff00dcf8e;p=linux.git net: sched: cls_bpf: use bitwise & rather than logical && on gen_flags Currently gen_flags is being operated on by a logical && operator rather than a bitwise & operator. This looks incorrect as these should be bit flag operations. Fix this. Detected by CoverityScan, CID#1460305 ("Logical vs. bitwise operator") Fixes: 3f7889c4c79b ("net: sched: cls_bpf: call block callbacks for offload) Signed-off-by: Colin Ian King Acked-by: Daniel Borkmann Signed-off-by: David S. Miller --- diff --git a/net/sched/cls_bpf.c b/net/sched/cls_bpf.c index 5f701c8670a26..bc3edde1b9d73 100644 --- a/net/sched/cls_bpf.c +++ b/net/sched/cls_bpf.c @@ -174,7 +174,7 @@ static int cls_bpf_offload_cmd(struct tcf_proto *tp, struct cls_bpf_prog *prog, } } - if (addorrep && skip_sw && !(prog->gen_flags && TCA_CLS_FLAGS_IN_HW)) + if (addorrep && skip_sw && !(prog->gen_flags & TCA_CLS_FLAGS_IN_HW)) return -EINVAL; return 0;