From: Li Zhong <floridsleeves@gmail.com>
Date: Sat, 3 Sep 2022 23:10:39 +0000 (-0700)
Subject: ata: libata-core: Check errors in sata_print_link_status()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=55d5ba550535c970c03cd0d0008ad1d61b238be4;p=linux.git

ata: libata-core: Check errors in sata_print_link_status()

sata_scr_read() could return negative error code on failure. Check the
return value when reading the control register.

Signed-off-by: Li Zhong <floridsleeves@gmail.com>
Signed-off-by: Damien Le Moal <damien.lemoal@opensource.wdc.com>
---

diff --git a/drivers/ata/libata-core.c b/drivers/ata/libata-core.c
index d0242c75aac59..75b86913db1ac 100644
--- a/drivers/ata/libata-core.c
+++ b/drivers/ata/libata-core.c
@@ -3021,7 +3021,8 @@ static void sata_print_link_status(struct ata_link *link)
 
 	if (sata_scr_read(link, SCR_STATUS, &sstatus))
 		return;
-	sata_scr_read(link, SCR_CONTROL, &scontrol);
+	if (sata_scr_read(link, SCR_CONTROL, &scontrol))
+		return;
 
 	if (ata_phys_link_online(link)) {
 		tmp = (sstatus >> 4) & 0xf;