From: David Sterba <dsterba@suse.com>
Date: Tue, 6 Feb 2024 22:06:46 +0000 (+0100)
Subject: btrfs: change BUG_ON to assertion in tree_move_down()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=56f335e043ae73c32dbb70ba95488845dc0f1e6e;p=linux.git

btrfs: change BUG_ON to assertion in tree_move_down()

There's only one caller of tree_move_down() that does not pass level 0
so the assertion is better suited here.

Signed-off-by: David Sterba <dsterba@suse.com>
---

diff --git a/fs/btrfs/send.c b/fs/btrfs/send.c
index 5b7ec4f99aad4..dc18d5624ec73 100644
--- a/fs/btrfs/send.c
+++ b/fs/btrfs/send.c
@@ -7447,8 +7447,8 @@ static int tree_move_down(struct btrfs_path *path, int *level, u64 reada_min_gen
 	u64 reada_done = 0;
 
 	lockdep_assert_held_read(&parent->fs_info->commit_root_sem);
+	ASSERT(*level != 0);
 
-	BUG_ON(*level == 0);
 	eb = btrfs_read_node_slot(parent, slot);
 	if (IS_ERR(eb))
 		return PTR_ERR(eb);