From: Will Deacon Date: Thu, 14 Jan 2021 15:44:09 +0000 (+0000) Subject: mm: Mark anonymous struct field of 'struct vm_fault' as 'const' X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5857c9209ce58f8e262889539ccdf63e73ad7a93;p=linux.git mm: Mark anonymous struct field of 'struct vm_fault' as 'const' The fields of this struct are only ever read after being initialised, so mark it 'const' before somebody tries to modify it again. GCC will then complain (with an error) about modification of these fields after they have been initialised, although LLVM currently allows them without even a warning: https://bugs.llvm.org/show_bug.cgi?id=48755 Hopefully, future versions of LLVM will emit a warning. Cc: Kirill A. Shutemov Cc: Linus Torvalds Signed-off-by: Will Deacon --- diff --git a/include/linux/mm.h b/include/linux/mm.h index e0f056753bef1..7ff3d9817d388 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -514,7 +514,7 @@ static inline bool fault_flag_allow_retry_first(unsigned int flags) * pgoff should be used in favour of virtual_address, if possible. */ struct vm_fault { - struct { + const struct { struct vm_area_struct *vma; /* Target VMA */ gfp_t gfp_mask; /* gfp mask to be used for allocations */ pgoff_t pgoff; /* Logical page offset based on vma */