From: David Matlack Date: Wed, 19 Jan 2022 23:07:29 +0000 (+0000) Subject: KVM: x86/mmu: Remove unnecessary warnings from restore_acc_track_spte() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=59940e76d13da7d0b5f81194be7a17ad4639bcd3;p=linux.git KVM: x86/mmu: Remove unnecessary warnings from restore_acc_track_spte() The warnings in restore_acc_track_spte() can be removed because the only caller checks is_access_track_spte(), and is_access_track_spte() checks !spte_ad_enabled(). In other words, the warning can never be triggered. No functional change intended. Suggested-by: Sean Christopherson Signed-off-by: David Matlack Message-Id: <20220119230739.2234394-9-dmatlack@google.com> Signed-off-by: Paolo Bonzini --- diff --git a/arch/x86/kvm/mmu/mmu.c b/arch/x86/kvm/mmu/mmu.c index 443c1b35fc7a1..51b9cb91b9e7b 100644 --- a/arch/x86/kvm/mmu/mmu.c +++ b/arch/x86/kvm/mmu/mmu.c @@ -652,9 +652,6 @@ static u64 restore_acc_track_spte(u64 spte) u64 saved_bits = (spte >> SHADOW_ACC_TRACK_SAVED_BITS_SHIFT) & SHADOW_ACC_TRACK_SAVED_BITS_MASK; - WARN_ON_ONCE(spte_ad_enabled(spte)); - WARN_ON_ONCE(!is_access_track_spte(spte)); - new_spte &= ~shadow_acc_track_mask; new_spte &= ~(SHADOW_ACC_TRACK_SAVED_BITS_MASK << SHADOW_ACC_TRACK_SAVED_BITS_SHIFT);