From: Hans Verkuil Date: Thu, 26 Jan 2023 12:33:10 +0000 (+0100) Subject: media: marvell: change return to goto for proper unwind X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5a1a39a8ac30c7f116d427f7271927d976e4723e;p=linux.git media: marvell: change return to goto for proper unwind The probe function used 'goto out' everywhere, except in one place where it returned an error. That too should be a 'goto out'. This fixes a smatch warning: mmp-driver.c:257 mmpcam_probe() warn: missing unwind goto? Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab --- diff --git a/drivers/media/platform/marvell/mmp-driver.c b/drivers/media/platform/marvell/mmp-driver.c index df16899ab1cbe..ef22bf8f276ca 100644 --- a/drivers/media/platform/marvell/mmp-driver.c +++ b/drivers/media/platform/marvell/mmp-driver.c @@ -254,7 +254,7 @@ static int mmpcam_probe(struct platform_device *pdev) */ ret = mccic_register(mcam); if (ret) - return ret; + goto out; /* * Add OF clock provider.