From: Hans de Goede <hdegoede@redhat.com>
Date: Mon, 29 Aug 2022 10:35:43 +0000 (+0200)
Subject: media: atomisp: Fix v4l2_fh resource leak on open errors
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5b9853ad1329be49343a608d574eb232ff1273d0;p=linux.git

media: atomisp: Fix v4l2_fh resource leak on open errors

When atomisp_open() fails then it must call v4l2_fh_release() to undo
the results of v4l2_fh_open().

Reviewed-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Mauro Carvalho Chehab <mchehab@kernel.org>
---

diff --git a/drivers/staging/media/atomisp/pci/atomisp_fops.c b/drivers/staging/media/atomisp/pci/atomisp_fops.c
index 6518e6d5c7b53..61571f3fb0604 100644
--- a/drivers/staging/media/atomisp/pci/atomisp_fops.c
+++ b/drivers/staging/media/atomisp/pci/atomisp_fops.c
@@ -804,6 +804,7 @@ css_error:
 	pm_runtime_put(vdev->v4l2_dev->dev);
 error:
 	rt_mutex_unlock(&isp->mutex);
+	v4l2_fh_release(file);
 	return ret;
 }