From: Jan Kara Date: Wed, 7 Dec 2022 11:27:07 +0000 (+0100) Subject: ext4: drop pointless IO submission from ext4_bio_write_page() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5c27088b3bcf82c8525ec55cde7d2ddd034283b6;p=linux.git ext4: drop pointless IO submission from ext4_bio_write_page() We submit outstanding IO in ext4_bio_write_page() if we find a buffer we are not going to write. This is however pointless because we already handle submission of previous IO in case we detect newly added buffer head is discontiguous. So just delete the pointless IO submission call. Reviewed-by: Ritesh Harjani (IBM) Signed-off-by: Jan Kara Link: https://lore.kernel.org/r/20221207112722.22220-4-jack@suse.cz Signed-off-by: Theodore Ts'o --- diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index 2bdfb8a046d9f..beaec6d81074a 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -489,8 +489,6 @@ int ext4_bio_write_page(struct ext4_io_submit *io, redirty_page_for_writepage(wbc, page); keep_towrite = true; } - if (io->io_bio) - ext4_io_submit(io); continue; } if (buffer_new(bh))