From: Takashi Iwai Date: Wed, 11 Mar 2020 08:47:09 +0000 (+0100) Subject: carl9170: Use scnprintf() for avoiding potential buffer overflow X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5cb5b4759cf6febe49bf23b7a0f362ac37e21b01;p=linux.git carl9170: Use scnprintf() for avoiding potential buffer overflow Since snprintf() returns the would-be-output size instead of the actual output size, the succeeding calls may go beyond the given buffer limit. Fix it by replacing with scnprintf(). Cc: Christian Lamparter Signed-off-by: Takashi Iwai Signed-off-by: Kalle Valo --- diff --git a/drivers/net/wireless/ath/carl9170/debug.c b/drivers/net/wireless/ath/carl9170/debug.c index a9b6dc17e4087..19009aafc4e16 100644 --- a/drivers/net/wireless/ath/carl9170/debug.c +++ b/drivers/net/wireless/ath/carl9170/debug.c @@ -45,7 +45,7 @@ #include "cmd.h" #define ADD(buf, off, max, fmt, args...) \ - off += snprintf(&buf[off], max - off, fmt, ##args); + off += scnprintf(&buf[off], max - off, fmt, ##args); struct carl9170_debugfs_fops {