From: Yang Yingliang <yangyingliang@huawei.com>
Date: Thu, 21 Jul 2022 07:12:00 +0000 (+0800)
Subject: usb: typec: anx7411: Fix return value check in anx7411_register_i2c_dummy_clients()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5cda657679f8fcb2896e4ac0aa8e231f12f9fb04;p=linux.git

usb: typec: anx7411: Fix return value check in anx7411_register_i2c_dummy_clients()

If i2c_new_dummy_device() fails, it never return NULL pointer, replace
NULL test with IS_ERR() to fix it.

Fixes: fe6d8a9c8e64 ("usb: typec: anx7411: Add Analogix PD ANX7411 support")
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Link: https://lore.kernel.org/r/20220721071201.269344-2-yangyingliang@huawei.com
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
---

diff --git a/drivers/usb/typec/anx7411.c b/drivers/usb/typec/anx7411.c
index e16c2d511e8ff..7692e26911b7a 100644
--- a/drivers/usb/typec/anx7411.c
+++ b/drivers/usb/typec/anx7411.c
@@ -999,7 +999,7 @@ static int anx7411_register_i2c_dummy_clients(struct anx7411_data *ctx,
 			spi_addr = anx7411_i2c_addr[i].spi_address >> 1;
 			ctx->spi_client = i2c_new_dummy_device(client->adapter,
 							       spi_addr);
-			if (ctx->spi_client)
+			if (!IS_ERR(ctx->spi_client))
 				return 0;
 		}
 	}