From: Alexey Dobriyan Date: Fri, 8 Jun 2018 00:10:17 +0000 (-0700) Subject: proc: use "unsigned int" for /proc/*/stack X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5d008fb414f7c73e0761835d941943e17d32463d;p=linux.git proc: use "unsigned int" for /proc/*/stack struct stack_trace::nr_entries is defined as "unsigned int" (YAY!) so the iterator should be unsigned as well. It saves 1 byte of code or something like that. Link: http://lkml.kernel.org/r/20180423215248.GG9043@avx2 Signed-off-by: Alexey Dobriyan Reviewed-by: Andrew Morton Cc: Al Viro Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds --- diff --git a/fs/proc/base.c b/fs/proc/base.c index 720205aa1e347..44dec22e5e9e6 100644 --- a/fs/proc/base.c +++ b/fs/proc/base.c @@ -401,7 +401,6 @@ static int proc_pid_stack(struct seq_file *m, struct pid_namespace *ns, struct stack_trace trace; unsigned long *entries; int err; - int i; entries = kmalloc(MAX_STACK_TRACE_DEPTH * sizeof(*entries), GFP_KERNEL); if (!entries) @@ -414,6 +413,8 @@ static int proc_pid_stack(struct seq_file *m, struct pid_namespace *ns, err = lock_trace(task); if (!err) { + unsigned int i; + save_stack_trace_tsk(task, &trace); for (i = 0; i < trace.nr_entries; i++) {