From: Dan Carpenter Date: Tue, 14 Mar 2017 07:55:01 +0000 (+0300) Subject: staging: atomisp: silence an array overflow warning X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5d1ae279c235e5f353d0f11e6b4bed3079732327;p=linux.git staging: atomisp: silence an array overflow warning Static checkers complain that we should check if "i" is in bounds before we check if "var8[i]" is a NUL char. This bug is harmless but also easy to fix. Signed-off-by: Dan Carpenter Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c index 292949273d008..add00932f6c9a 100644 --- a/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c +++ b/drivers/staging/media/atomisp/platform/intel-mid/atomisp_gmin_platform.c @@ -669,7 +669,7 @@ int gmin_get_config_var(struct device *dev, const char *var, char *out, size_t * /* Our variable names are ASCII by construction, but EFI names * are wide chars. Convert and zero-pad. */ memset(var16, 0, sizeof(var16)); - for (i=0; var8[i] && i < sizeof(var8); i++) + for (i = 0; i < sizeof(var8) && var8[i]; i++) var16[i] = var8[i]; /* To avoid owerflows when calling the efivar API */