From: David S. Miller <davem@davemloft.net>
Date: Sun, 16 Jun 2019 01:10:30 +0000 (-0700)
Subject: Revert "net: phylink: set the autoneg state in phylink_phy_change"
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5db2e7c7917f40236a021959893121c4e496f609;p=linux.git

Revert "net: phylink: set the autoneg state in phylink_phy_change"

This reverts commit ef7bfa84725d891bbdb88707ed55b2cbf94942bb.

Russell King espressed some strong opposition to this
change, explaining that this is trying to make phylink
behave outside of how it has been designed.

Signed-off-by: David S. Miller <davem@davemloft.net>
---

diff --git a/drivers/net/phy/phylink.c b/drivers/net/phy/phylink.c
index c638e13fbf81d..4c0616ba314d3 100644
--- a/drivers/net/phy/phylink.c
+++ b/drivers/net/phy/phylink.c
@@ -635,7 +635,6 @@ static void phylink_phy_change(struct phy_device *phydev, bool up,
 		pl->phy_state.pause |= MLO_PAUSE_ASYM;
 	pl->phy_state.interface = phydev->interface;
 	pl->phy_state.link = up;
-	pl->phy_state.an_enabled = phydev->autoneg;
 	mutex_unlock(&pl->state_mutex);
 
 	phylink_run_resolve(pl);