From: Dr. David Alan Gilbert <dgilbert@redhat.com>
Date: Wed, 18 Nov 2015 11:48:41 +0000 (+0000)
Subject: Unneeded NULL check
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5df5416e639cd75bd85d243af41387c2418fa580;p=qemu.git

Unneeded NULL check

The check is unneccesary, we read the value at the start of the
thread, use it, and never change it.  The value is checked to be
non-NULL before thread creation.

Spotted by coverity, CID 1339211

Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Juan Quintela <quintela@redhat.com>
---

diff --git a/migration/migration.c b/migration/migration.c
index 265d13a74f..1a42aee412 100644
--- a/migration/migration.c
+++ b/migration/migration.c
@@ -1345,7 +1345,7 @@ static void *source_return_path_thread(void *opaque)
             break;
         }
     }
-    if (rp && qemu_file_get_error(rp)) {
+    if (qemu_file_get_error(rp)) {
         trace_source_return_path_thread_bad_end();
         mark_source_rp_bad(ms);
     }