From: Adrian Hunter Date: Mon, 25 Mar 2024 06:40:08 +0000 (+0200) Subject: math64: Tidy up mul_u64_u32_shr() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5e5e51422cd189bc1b627f619f0f99324e6e4de9;p=linux.git math64: Tidy up mul_u64_u32_shr() Put together declaration and initialization of local variables. Suggested-by: Thomas Gleixner Signed-off-by: Adrian Hunter Signed-off-by: Thomas Gleixner Link: https://lore.kernel.org/r/20240325064023.2997-5-adrian.hunter@intel.com --- diff --git a/include/linux/math64.h b/include/linux/math64.h index bf74478926d4a..fd13622b2056e 100644 --- a/include/linux/math64.h +++ b/include/linux/math64.h @@ -179,16 +179,12 @@ static __always_inline u64 mul_u64_u64_shr(u64 a, u64 mul, unsigned int shift) #ifndef mul_u64_u32_shr static __always_inline u64 mul_u64_u32_shr(u64 a, u32 mul, unsigned int shift) { - u32 ah, al; + u32 ah = a >> 32, al = a; u64 ret; - al = a; - ah = a >> 32; - ret = mul_u32_u32(al, mul) >> shift; if (ah) ret += mul_u32_u32(ah, mul) << (32 - shift); - return ret; } #endif /* mul_u64_u32_shr */