From: Colin Ian King Date: Thu, 9 Apr 2020 13:41:26 +0000 (+0100) Subject: net-sysfs: remove redundant assignment to variable ret X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5f0224a6ddc3101ab9664a5f7a6287047934a079;p=linux.git net-sysfs: remove redundant assignment to variable ret The variable ret is being initialized with a value that is never read and it is being updated later with a new value. The initialization is redundant and can be removed. Addresses-Coverity: ("Unused value") Signed-off-by: Colin Ian King Signed-off-by: David S. Miller --- diff --git a/net/core/net-sysfs.c b/net/core/net-sysfs.c index cf0215734ceb0..4773ad6ec1114 100644 --- a/net/core/net-sysfs.c +++ b/net/core/net-sysfs.c @@ -80,7 +80,7 @@ static ssize_t netdev_store(struct device *dev, struct device_attribute *attr, struct net_device *netdev = to_net_dev(dev); struct net *net = dev_net(netdev); unsigned long new; - int ret = -EINVAL; + int ret; if (!ns_capable(net->user_ns, CAP_NET_ADMIN)) return -EPERM;