From: Dan Carpenter <dan.carpenter@oracle.com>
Date: Tue, 19 Jul 2022 09:48:01 +0000 (+0300)
Subject: md/raid5: missing error code in setup_conf()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5f7ef4875f99538b741527963ffe09e869b49826;p=linux.git

md/raid5: missing error code in setup_conf()

Return -ENOMEM if the allocation fails.  Don't return success.

Fixes: 8fbcba6b999b ("md/raid5: Cleanup setup_conf() error returns")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Signed-off-by: Song Liu <song@kernel.org>
---

diff --git a/drivers/md/raid5.c b/drivers/md/raid5.c
index 5d09256d7f818..96c3a11857813 100644
--- a/drivers/md/raid5.c
+++ b/drivers/md/raid5.c
@@ -7304,7 +7304,9 @@ static struct r5conf *setup_conf(struct mddev *mddev)
 		goto abort;
 	conf->mddev = mddev;
 
-	if ((conf->stripe_hashtbl = kzalloc(PAGE_SIZE, GFP_KERNEL)) == NULL)
+	ret = -ENOMEM;
+	conf->stripe_hashtbl = kzalloc(PAGE_SIZE, GFP_KERNEL);
+	if (!conf->stripe_hashtbl)
 		goto abort;
 
 	/* We init hash_locks[0] separately to that it can be used