From: Mateusz Jończyk Date: Sat, 12 Feb 2022 12:56:54 +0000 (+0100) Subject: hwmon: (dell-smm) rewrite CONFIG_I8K description X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5f86cce61c1d12219b2ea25b9404bf263a77dd72;p=linux.git hwmon: (dell-smm) rewrite CONFIG_I8K description It is not the laptops, but the /proc/i8k interface that is legacy (or so I think was the intention of the help text author). The old description was confusing, fix this. The phrase "Say Y if you intend to run this kernel on old Dell laptops or want to use userspace package i8kutils." was introduced in 2015, in commit 039ae58503f3 ("hwmon: Allow to compile dell-smm-hwmon driver without /proc/i8k") I think that "old laptops" was about hotkey and Fn key support - this driver in the 2.4 kernels' era apparently had these capabilities (see: https://github.com/vitorafsr/i8kutils , description of "repeat_rate" kernel module parameter). Signed-off-by: Mateusz Jończyk Cc: Pali Rohár Cc: Jean Delvare Cc: Guenter Roeck Cc: Mark Gross Reviewed-by: Hans de Goede Reviewed-by: Randy Dunlap Link: https://lore.kernel.org/r/20220212125654.357408-2-mat.jonczyk@o2.pl Signed-off-by: Guenter Roeck --- diff --git a/drivers/hwmon/Kconfig b/drivers/hwmon/Kconfig index fceea537101de..ce9149e0648f9 100644 --- a/drivers/hwmon/Kconfig +++ b/drivers/hwmon/Kconfig @@ -507,19 +507,18 @@ config SENSORS_DELL_SMM userspace interface for i8kutils package. config I8K - bool "Dell i8k legacy laptop support" + bool "Legacy /proc/i8k interface of Dell laptop SMM BIOS hwmon driver" depends on SENSORS_DELL_SMM depends on PROC_FS help - This option enables legacy /proc/i8k userspace interface in hwmon - dell-smm-hwmon driver. Character file /proc/i8k reports bios version, - temperature and allows controlling fan speeds of Dell laptops via - System Management Mode. For old Dell laptops (like Dell Inspiron 8000) - it reports also power and hotkey status. For fan speed control is - needed userspace package i8kutils. + This option enables the legacy /proc/i8k userspace interface of the + dell-smm-hwmon driver. The character file /proc/i8k exposes the BIOS + version, temperatures and allows control of fan speeds of some Dell + laptops. Sometimes it also reports power and hotkey status. - Say Y if you intend to run this kernel on old Dell laptops or want to - use userspace package i8kutils. + This interface is required to run programs from the i8kutils package. + + Say Y if you intend to run userspace programs that use this interface. Say N otherwise. config SENSORS_DA9052_ADC