From: Dan Carpenter Date: Wed, 27 Sep 2023 12:39:43 +0000 (+0300) Subject: media: nuvoton: npcm-video: Fix IS_ERR() vs NULL bug X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=5f9fcbf92da901495f2f8b09d2f6df5c2ca83dc5;p=linux.git media: nuvoton: npcm-video: Fix IS_ERR() vs NULL bug The of_parse_phandle() function returns NULL on error. It never returns error pointers. Update the check accordingly. Fixes: 70721089985c ("media: nuvoton: Add driver for NPCM video capture and encoding engine") Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil --- diff --git a/drivers/media/platform/nuvoton/npcm-video.c b/drivers/media/platform/nuvoton/npcm-video.c index ac8d73b794d37..b9e6782f59b42 100644 --- a/drivers/media/platform/nuvoton/npcm-video.c +++ b/drivers/media/platform/nuvoton/npcm-video.c @@ -1660,9 +1660,9 @@ static int npcm_video_ece_init(struct npcm_video *video) void __iomem *regs; ece_node = of_parse_phandle(video->dev->of_node, "nuvoton,ece", 0); - if (IS_ERR(ece_node)) { + if (!ece_node) { dev_err(dev, "Failed to get ECE phandle in DTS\n"); - return PTR_ERR(ece_node); + return -ENODEV; } video->ece.enable = of_device_is_available(ece_node);