From: Sven Peter Date: Sun, 26 Nov 2023 16:20:09 +0000 (+0100) Subject: iommu/apple-dart: Use readl instead of readl_relaxed for consistency X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=60732292a135e8b8152858f219a563c05e9569e9;p=linux.git iommu/apple-dart: Use readl instead of readl_relaxed for consistency While the readl_relaxed in apple_dart_suspend is correct the rest of the driver uses the non-relaxed variants everywhere and the single readl_relaxed is inconsistent and possibly confusing. Signed-off-by: Sven Peter Acked-by: Hector Martin Reviewed-by: Neal Gompa Link: https://lore.kernel.org/r/20231126162009.17934-1-sven@svenpeter.dev Signed-off-by: Joerg Roedel --- diff --git a/drivers/iommu/apple-dart.c b/drivers/iommu/apple-dart.c index f47f60c0a4d0d..7438e9c82ba98 100644 --- a/drivers/iommu/apple-dart.c +++ b/drivers/iommu/apple-dart.c @@ -1302,7 +1302,7 @@ static __maybe_unused int apple_dart_suspend(struct device *dev) unsigned int sid, idx; for (sid = 0; sid < dart->num_streams; sid++) { - dart->save_tcr[sid] = readl_relaxed(dart->regs + DART_TCR(dart, sid)); + dart->save_tcr[sid] = readl(dart->regs + DART_TCR(dart, sid)); for (idx = 0; idx < dart->hw->ttbr_count; idx++) dart->save_ttbr[sid][idx] = readl(dart->regs + DART_TTBR(dart, sid, idx));