From: Yang Guang <yang.guang5@zte.com.cn>
Date: Thu, 4 Nov 2021 01:14:56 +0000 (+0800)
Subject: macintosh/adb: Use swap() to make code cleaner
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6130ed79decc38b873deb582678ac81caefd5555;p=linux.git

macintosh/adb: Use swap() to make code cleaner

Use the macro 'swap()' defined in 'include/linux/minmax.h' to avoid
opencoding it.

Reported-by: Zeal Robot <zealci@zte.com.cn>
Signed-off-by: Yang Guang <yang.guang5@zte.com.cn>
Signed-off-by: Christophe Leroy <christophe.leroy@csgroup.eu>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
Link: https://lore.kernel.org/r/20211104011456.1027830-1-yang.guang5@zte.com.cn
---

diff --git a/drivers/macintosh/adbhid.c b/drivers/macintosh/adbhid.c
index 1d355aa9a1ddd..b2fe7a3dc4713 100644
--- a/drivers/macintosh/adbhid.c
+++ b/drivers/macintosh/adbhid.c
@@ -816,9 +816,7 @@ adbhid_input_register(int id, int default_id, int original_handler_id,
 		case 0xC4: case 0xC7:
 			keyboard_type = "ISO, swapping keys";
 			input_dev->id.version = ADB_KEYBOARD_ISO;
-			i = hid->keycode[10];
-			hid->keycode[10] = hid->keycode[50];
-			hid->keycode[50] = i;
+			swap(hid->keycode[10], hid->keycode[50]);
 			break;
 
 		case 0x12: case 0x15: case 0x16: case 0x17: case 0x1A: