From: Dan Carpenter Date: Mon, 22 Nov 2021 07:41:47 +0000 (+0300) Subject: drm/i915/ttm: Fix error code in i915_ttm_eviction_valuable() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6164807dd2989fd4c1435a6b3c61453e63c4e37e;p=linux.git drm/i915/ttm: Fix error code in i915_ttm_eviction_valuable() This function returns a bool type so returning -EBUSY is equivalent to returning true. It should return false instead. Fixes: 7ae034590cea ("drm/i915/ttm: add tt shmem backend") Signed-off-by: Dan Carpenter Reviewed-by: Matthew Auld Signed-off-by: Matthew Auld Link: https://patchwork.freedesktop.org/patch/msgid/20211122061438.GA2492@kili --- diff --git a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c index d08a270b0921a..753f0f5458b65 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ttm.c +++ b/drivers/gpu/drm/i915/gem/i915_gem_ttm.c @@ -332,7 +332,7 @@ static bool i915_ttm_eviction_valuable(struct ttm_buffer_object *bo, * but we would like to avoid grabbing locks for no good reason. */ if (bo->ttm && bo->ttm->page_flags & TTM_TT_FLAG_EXTERNAL) - return -EBUSY; + return false; /* Will do for now. Our pinned objects are still on TTM's LRU lists */ return i915_gem_object_evictable(obj);