From: Lukas Czerner Date: Wed, 3 Oct 2018 01:18:45 +0000 (-0400) Subject: ext4: initialize retries variable in ext4_da_write_inline_data_begin() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=625ef8a3acd111d5f496d190baf99d1a815bd03e;p=linux.git ext4: initialize retries variable in ext4_da_write_inline_data_begin() Variable retries is not initialized in ext4_da_write_inline_data_begin() which can lead to nondeterministic number of retries in case we hit ENOSPC. Initialize retries to zero as we do everywhere else. Signed-off-by: Lukas Czerner Signed-off-by: Theodore Ts'o Fixes: bc0ca9df3b2a ("ext4: retry allocation when inline->extent conversion failed") Cc: stable@kernel.org --- diff --git a/fs/ext4/inline.c b/fs/ext4/inline.c index 7b47360227612..9c4bac18cc6c0 100644 --- a/fs/ext4/inline.c +++ b/fs/ext4/inline.c @@ -863,7 +863,7 @@ int ext4_da_write_inline_data_begin(struct address_space *mapping, handle_t *handle; struct page *page; struct ext4_iloc iloc; - int retries; + int retries = 0; ret = ext4_get_inode_loc(inode, &iloc); if (ret)