From: Geert Uytterhoeven <geert@linux-m68k.org>
Date: Tue, 8 Jan 2019 14:00:03 +0000 (+0100)
Subject: dio: Fix buffer overflow in case of unknown board
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=627f192d1e1a2ddf5fb06201facb15d4c70b058f;p=linux.git

dio: Fix buffer overflow in case of unknown board

With gcc 8.2.0:

    drivers/dio/dio.c: In function ‘dio_init’:
    drivers/dio/dio.c:240:17: warning: ‘strcpy’ writing 69 or more bytes into a region of size 64 overflows the destination [-Wstringop-overflow=]
		     strcpy(dev->name,dio_getname(dev->id));
		     ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Indeed, if an unknown board is present, the target buffer will overflow.
Shorten the unknown board name string to fix this, and declare it as an
array while at it.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---

diff --git a/drivers/dio/dio.c b/drivers/dio/dio.c
index 92e78d16b4765..c9aa15fb86a9a 100644
--- a/drivers/dio/dio.c
+++ b/drivers/dio/dio.c
@@ -89,8 +89,8 @@ static struct dioname names[] =
 #undef DIONAME
 #undef DIOFBNAME
 
-static const char *unknowndioname 
-        = "unknown DIO board -- please email <linux-m68k@lists.linux-m68k.org>!";
+static const char unknowndioname[]
+	= "unknown DIO board, please email linux-m68k@lists.linux-m68k.org";
 
 static const char *dio_getname(int id)
 {