From: Richard Guy Briggs <rgb@redhat.com>
Date: Mon, 12 Feb 2018 10:04:53 +0000 (-0500)
Subject: audit: session ID should not set arch quick field pointer
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6387440e15db1c9ee58028433cd87291cae488e7;p=linux.git

audit: session ID should not set arch quick field pointer

A bug was introduced in 8fae47705685fcaa75a1fe4c8c3e18300a702979
("audit: add support for session ID user filter")
See: https://github.com/linux-audit/audit-kernel/issues/4

When setting a session ID filter, the session ID filter field overwrote
the quick pointer reference to the arch field, potentially causing the
arch field to be misinterpreted.

Passes audit-testsuite.

Signed-off-by: Richard Guy Briggs <rgb@redhat.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
---

diff --git a/kernel/auditfilter.c b/kernel/auditfilter.c
index 4a1758adb2224..739a6d2d4df88 100644
--- a/kernel/auditfilter.c
+++ b/kernel/auditfilter.c
@@ -496,7 +496,6 @@ static struct audit_entry *audit_data_to_entry(struct audit_rule_data *data,
 			if (!gid_valid(f->gid))
 				goto exit_free;
 			break;
-		case AUDIT_SESSIONID:
 		case AUDIT_ARCH:
 			entry->rule.arch_f = f;
 			break;