From: Uwe Kleine-König Date: Thu, 14 Jan 2021 17:57:18 +0000 (+0100) Subject: tty: vcc: Drop impossible to hit WARN_ON X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=63e34e707c6248645da340d4aff7714ec27b5fb1;p=linux.git tty: vcc: Drop impossible to hit WARN_ON vcc_get() returns the port that has provided port->index. As the port that is about to be removed isn't removed yet this trivially will find this port. So simplify the call to not assign an identical value to the port pointer and drop the warning that is never hit. Reviewed-by: Jiri Slaby Signed-off-by: Uwe Kleine-König Link: https://lore.kernel.org/r/20210114175718.137483-4-u.kleine-koenig@pengutronix.de Signed-off-by: Greg Kroah-Hartman --- diff --git a/drivers/tty/vcc.c b/drivers/tty/vcc.c index d9b0dc6deae91..e2d6205f83ce1 100644 --- a/drivers/tty/vcc.c +++ b/drivers/tty/vcc.c @@ -692,12 +692,9 @@ static int vcc_remove(struct vio_dev *vdev) tty_vhangup(port->tty); /* Get exclusive reference to VCC, ensures that there are no other - * clients to this port + * clients to this port. This cannot fail. */ - port = vcc_get(port->index, true); - - if (WARN_ON(!port)) - return -ENODEV; + vcc_get(port->index, true); tty_unregister_device(vcc_tty_driver, port->index);