From: Eduardo Habkost <ehabkost@redhat.com>
Date: Tue, 15 Dec 2020 22:41:33 +0000 (-0500)
Subject: qom: Assert that objects being destroyed have no parent
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=63f957ac96eba545ef60abebfc6741d06fd99ade;p=qemu.git

qom: Assert that objects being destroyed have no parent

QOM reference counting bugs are often hard to detect, but there's
one kind of bug that's easier: if we are freeing an object but is
still attached to a parent, it means the reference count is wrong
(because the parent always hold a reference to their children).

Add an assertion to make sure we detect those cases.

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Message-Id: <20201215224133.3545901-3-ehabkost@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---

diff --git a/qom/object.c b/qom/object.c
index 5cd43fe366..2fa0119647 100644
--- a/qom/object.c
+++ b/qom/object.c
@@ -685,6 +685,7 @@ static void object_finalize(void *data)
     object_deinit(obj, ti);
 
     g_assert(obj->ref == 0);
+    g_assert(obj->parent == NULL);
     if (obj->free) {
         obj->free(obj);
     }