From: Yang Yingliang <yangyingliang@huawei.com>
Date: Tue, 28 Jun 2022 14:02:49 +0000 (+0800)
Subject: soc: fsl: guts: check return value after calling of_iomap() in fsl_guts_get_soc_uid()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=63f98153075167a6c88d8ac90bfd26f1887c670c;p=linux.git

soc: fsl: guts: check return value after calling of_iomap() in fsl_guts_get_soc_uid()

of_iomap() may return NULL, so we need check the return value.

Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Yang Yingliang <yangyingliang@huawei.com>
Reviewed-by: Michael Walle <michael@walle.cc>
Signed-off-by: Shawn Guo <shawnguo@kernel.org>
---

diff --git a/drivers/soc/fsl/guts.c b/drivers/soc/fsl/guts.c
index 8038c599ad839..6bf3e6a980ffc 100644
--- a/drivers/soc/fsl/guts.c
+++ b/drivers/soc/fsl/guts.c
@@ -126,6 +126,10 @@ static u64 fsl_guts_get_soc_uid(const char *compat, unsigned int offset)
 		return 0;
 
 	sfp_base = of_iomap(np, 0);
+	if (!sfp_base) {
+		of_node_put(np);
+		return 0;
+	}
 
 	uid = ioread32(sfp_base + offset);
 	uid <<= 32;