From: Rayagonda Kokatanur Date: Wed, 18 Mar 2020 03:30:55 +0000 (+0530) Subject: maillbox: bcm-flexrm-mailbox: handle cmpl_pool dma allocation failure X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=64d0da512b5ab856c25b59e692c5fa8feb93e62d;p=linux.git maillbox: bcm-flexrm-mailbox: handle cmpl_pool dma allocation failure Handle 'cmpl_pool' dma memory allocation failure. Fixes: a9a9da47f8e6 ("mailbox: no need to check return value of debugfs_create functions") Signed-off-by: Rayagonda Kokatanur Reviewed-by: Tyler Hicks Signed-off-by: Jassi Brar --- diff --git a/drivers/mailbox/bcm-flexrm-mailbox.c b/drivers/mailbox/bcm-flexrm-mailbox.c index 8ee9db2748029..bee33abb53084 100644 --- a/drivers/mailbox/bcm-flexrm-mailbox.c +++ b/drivers/mailbox/bcm-flexrm-mailbox.c @@ -1599,6 +1599,7 @@ static int flexrm_mbox_probe(struct platform_device *pdev) 1 << RING_CMPL_ALIGN_ORDER, 0); if (!mbox->cmpl_pool) { ret = -ENOMEM; + goto fail_destroy_bd_pool; } /* Allocate platform MSIs for each ring */ @@ -1661,6 +1662,7 @@ fail_free_debugfs_root: platform_msi_domain_free_irqs(dev); fail_destroy_cmpl_pool: dma_pool_destroy(mbox->cmpl_pool); +fail_destroy_bd_pool: dma_pool_destroy(mbox->bd_pool); fail: return ret;