From: Sven Schnelle <svens@linux.ibm.com>
Date: Sun, 27 Nov 2022 08:26:24 +0000 (+0100)
Subject: s390/tty3270: use switch/case in tty3270_erase_display()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=65b77ccb1e292d3d2407bbe225995d7c4c39e721;p=linux.git

s390/tty3270: use switch/case in tty3270_erase_display()

This makes the code easier to read.

Signed-off-by: Sven Schnelle <svens@linux.ibm.com>
Acked-by: Heiko Carstens <hca@linux.ibm.com>
Tested-by: Niklas Schnelle <schnelle@linux.ibm.com>
Signed-off-by: Heiko Carstens <hca@linux.ibm.com>
---

diff --git a/drivers/s390/char/con3270.c b/drivers/s390/char/con3270.c
index 90671dd62cb36..84e8e077c5742 100644
--- a/drivers/s390/char/con3270.c
+++ b/drivers/s390/char/con3270.c
@@ -1337,25 +1337,29 @@ static void tty3270_erase_line(struct tty3270 *tp, int mode)
  */
 static void tty3270_erase_display(struct tty3270 *tp, int mode)
 {
-	int i;
+	int i, start, end;
 
-	if (mode == 0) {
+	switch (mode) {
+	case 0:
 		tty3270_erase_line(tp, 0);
-		for (i = tp->cy + 1; i < tp->view.rows - 2; i++) {
-			tp->screen[i].len = 0;
-			tty3270_convert_line(tp, i);
-		}
-	} else if (mode == 1) {
-		for (i = 0; i < tp->cy; i++) {
-			tp->screen[i].len = 0;
-			tty3270_convert_line(tp, i);
-		}
+		start = tp->cy + 1;
+		end = tp->view.rows - 2;
+		break;
+	case 1:
+		start = 0;
+		end = tp->cy;
 		tty3270_erase_line(tp, 1);
-	} else if (mode == 2) {
-		for (i = 0; i < tp->view.rows - 2; i++) {
-			tp->screen[i].len = 0;
-			tty3270_convert_line(tp, i);
-		}
+		break;
+	case 2:
+		start = 0;
+		end = tp->view.rows - 2;
+		break;
+	default:
+		return;
+	}
+	for (i = start; i < end; i++) {
+		tp->screen[i].len = 0;
+		tty3270_convert_line(tp, i);
 	}
 	tty3270_rebuild_update(tp);
 }