From: Jules Irenge Date: Wed, 29 Apr 2020 10:05:23 +0000 (+0100) Subject: usb: gadget: Add missing annotation for xudc_handle_setup() X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=66bd76e79e41eb79452e10d62f2099742a7feeb0;p=linux.git usb: gadget: Add missing annotation for xudc_handle_setup() Sparse reports a warning at xudc_handle_setup() warning: context imbalance in xudc_handle_setup() - unexpected unlock The root cause is the missing annotation at xudc_handle_setup() Add the missing __must_hold(&udc->lock) annotation Signed-off-by: Jules Irenge Signed-off-by: Felipe Balbi --- diff --git a/drivers/usb/gadget/udc/udc-xilinx.c b/drivers/usb/gadget/udc/udc-xilinx.c index b1cfc8279c3d2..709553bdb2339 100644 --- a/drivers/usb/gadget/udc/udc-xilinx.c +++ b/drivers/usb/gadget/udc/udc-xilinx.c @@ -1732,6 +1732,7 @@ static void xudc_set_clear_feature(struct xusb_udc *udc) * Process setup packet and delegate to gadget layer. */ static void xudc_handle_setup(struct xusb_udc *udc) + __must_hold(&udc->lock) { struct xusb_ep *ep0 = &udc->ep[0]; struct usb_ctrlrequest setup;