From: Tobin C. Harding <tobin@kernel.org>
Date: Wed, 15 May 2019 09:07:50 +0000 (+1000)
Subject: powerpc/cacheinfo: Remove double free
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=672eaf37db9f99fd794eed2c68a8b3b05d484081;p=linux.git

powerpc/cacheinfo: Remove double free

kfree() after kobject_put(). Who ever wrote this was on crack.

Fixes: 7e8039795a80 ("powerpc/cacheinfo: Fix kobject memleak")
Signed-off-by: Tobin C. Harding <tobin@kernel.org>
Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
---

diff --git a/arch/powerpc/kernel/cacheinfo.c b/arch/powerpc/kernel/cacheinfo.c
index f2ed3ef4b129d..862e2890bd3df 100644
--- a/arch/powerpc/kernel/cacheinfo.c
+++ b/arch/powerpc/kernel/cacheinfo.c
@@ -767,7 +767,6 @@ static void cacheinfo_create_index_dir(struct cache *cache, int index,
 				  cache_dir->kobj, "index%d", index);
 	if (rc) {
 		kobject_put(&index_dir->kobj);
-		kfree(index_dir);
 		return;
 	}