From: Laurent Vivier <laurent@vivier.eu>
Date: Wed, 8 Jul 2020 15:24:34 +0000 (+0200)
Subject: linux-user: fix the errno value in print_syscall_err()
X-Git-Url: http://git.maquefel.me/?a=commitdiff_plain;h=6733d57035d1c4a67070b8d737334c28e5c63bc6;p=qemu.git

linux-user: fix the errno value in print_syscall_err()

errno of the target is returned as a negative value by the syscall,
not in the host errno variable.

The emulation of the target syscall can return an error while the
host doesn't set an errno value. Target errnos and host errnos can
also differ in some cases.

Fixes: c84be71f6854 ("linux-user: Extend strace support to enable argument printing after syscall execution")
Cc: Filip.Bozuta@syrmia.com
Signed-off-by: Laurent Vivier <laurent@vivier.eu>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Filip Bozuta <Filip.Bozuta@syrmia.com>
Message-Id: <20200708152435.706070-2-laurent@vivier.eu>
---

diff --git a/linux-user/strace.c b/linux-user/strace.c
index 39554d9039..7769f53bd5 100644
--- a/linux-user/strace.c
+++ b/linux-user/strace.c
@@ -731,7 +731,7 @@ print_syscall_err(abi_long ret)
 
     qemu_log(" = ");
     if (ret < 0) {
-        qemu_log("-1 errno=%d", errno);
+        qemu_log("-1 errno=%d", (int)-ret);
         errstr = target_strerror(-ret);
         if (errstr) {
             qemu_log(" (%s)", errstr);